stream.ffmpegmux: disable -start_at_zero for -copyts as default#3413
Merged
Conversation
- don't use `-start_at_zero` as default for `-copyts` - revert streamlink#2559 - change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero` (there was no release in between this command) - use `--ffmpeg-start-at-zero` for the facebook plugin, because the original fix was for it. streamlink#2488
bastimeyer
approved these changes
Dec 13, 2020
bastimeyer
left a comment
Member
There was a problem hiding this comment.
Changes looking good. One thing to note though: ffmpeg-start-at-zero on the session should default to False, not to None. It's already documented as bool.
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 15, 2020
…lt (streamlink#3413) - don't use `-start_at_zero` as default for `-copyts` - revert streamlink#2559 - change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero` (there was no release in between this command) - use `--ffmpeg-start-at-zero` for the facebook plugin, because the original fix was for it. streamlink#2488
Member
|
Just for reference, |
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 17, 2020
…lt (streamlink#3413) - don't use `-start_at_zero` as default for `-copyts` - revert streamlink#2559 - change command `--ffmpeg-no-start-at-zero` to `--ffmpeg-start-at-zero` (there was no release in between this command) - use `--ffmpeg-start-at-zero` for the facebook plugin, because the original fix was for it. streamlink#2488
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't use
-start_at_zeroas default for-copytsrevert ffmpegmux: use -start_at_zero with -copyts #2559
change command
--ffmpeg-no-start-at-zeroto--ffmpeg-start-at-zero(there was no release in between this command)
use
--ffmpeg-start-at-zerofor the facebook plugin,because the original fix was for it.
Files of recorded of Facebook MPEG-DASH streams are broken #2488
as this might have some downsides
Might be helpful for #3404