add ffmpeg-copyts option#3404
Conversation
8d217d6 to
9d04f6a
Compare
5e8c6d5 to
9aef6f3
Compare
back-to
left a comment
There was a problem hiding this comment.
could you add some tests for
session.options.set("ffmpeg-copyts", False)
session.options.set("ffmpeg-copyts", True)similar to https://github.com/streamlink/streamlink/blob/master/tests/streams/test_ffmpegmux.py#L56-L117
e6a0579 to
808996d
Compare
Co-authored-by: Sebastian Meyer <[email protected]> Co-authored-by: Sebastian Meyer <[email protected]>
808996d to
3115a4c
Compare
bastimeyer
left a comment
There was a problem hiding this comment.
Please move all the definitions of ffmpeg-copyts up, so that it comes before ffmpeg-start-at-zero, as start-at-zero depends on copyts. In the Session, FFMPEGMuxer, argparser and cli.main.
Please why, I see no dependence? |
|
streamlink/src/streamlink/stream/ffmpegmux.py Lines 114 to 117 in ca1b966 |
It doesn’t matter which option comes first. |
|
it is basically just style git diff, git history would look better then now |
What's important here is the order of the CLI args in the docs / man page / help text. And since that definitely should be corrected, it doesn't make sense having the other code lines in a different order. |
|
Have a good excuse ;) |
hls-multistreams occasionally have an input offset between the audio and video streams and the sound is then out of sync. Withcopyts, the offset is not changed when outputting to the player so that the sound is in sync.