[youtube] Don't use MuxedStream for livestreams#1556
Merged
Conversation
- 60 FPS are provided from HLS streams now - added some debug messages - added url tests
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
=========================================
+ Coverage 32.78% 33% +0.22%
=========================================
Files 222 222
Lines 12370 12382 +12
=========================================
+ Hits 4055 4087 +32
+ Misses 8315 8295 -20 |
Member
|
Good stuff, thanks @back-to. |
4 tasks
1 task
1 task
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
[youtube] Don't use MuxedStream for livestreams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MuxedStream won't work because the HTTPStream's are chunked without a reload,
so it won't work currently.
But HLS streams are working with 60 FPS now, so there is no need for the DASH stream.
moved code from
_get_streamsinto_create_adaptive_streamscloses #1520