tests: test to ensure that all plugins are listed in the plugin matrix#1673
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
==========================================
- Coverage 33.4% 33.23% -0.17%
==========================================
Files 230 230
Lines 12960 12960
==========================================
- Hits 4329 4307 -22
- Misses 8631 8653 +22 |
Member
Author
|
Looking in to the -11% coverage... Update: really didn't like the MetaClass, so I removed it it will now fail on the first missing plugin matrix entry - but that should be fine for PRs anyway. |
849f3b6 to
d700ac8
Compare
d700ac8 to
1b04bf8
Compare
Member
Author
|
Reduction in coverage here appears to be due to unstable conditions for the tests, ie. it's not really a reduction in test coverage, also the line in question would be removed in #1658. |
Member
|
Cool, merging. Thanks @beardypig this is a good addition. |
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
tests: test to ensure that all plugins are listed in the plugin matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a test that tests to ensure that each plugin exists in the plugin matrix in the docs (excluding the built in plugins). I found these plugins didn't have a row in the docs: live_russia_tv, ok_live, piczel, streann, and teamliquid. I updated it as best I could, please point out an omissions/mistakes.