hls: support for live streams when using --hls-duration#1710
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
+ Coverage 34.8% 34.82% +0.01%
==========================================
Files 234 234
Lines 13226 13228 +2
==========================================
+ Hits 4603 4606 +3
+ Misses 8623 8622 -1 |
Member
|
Looks good, thanks @beardypig. |
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
hls: support for live streams when using --hls-duration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pcolmer asked if it was possible to stop a live stream after a given time in #1709. This PR enhances the functionality of the existing
--hls-durationoption to include support for live streams.Had to fix a test too, it didn't seem to be working as intended anyway.