logging: fixed issue with logging from plugins using logging module#1720
Merged
Conversation
e782898 to
9400da9
Compare
9400da9 to
d652bea
Compare
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
+ Coverage 36.95% 37.14% +0.18%
==========================================
Files 237 238 +1
Lines 13784 13826 +42
==========================================
+ Hits 5094 5135 +41
- Misses 8690 8691 +1 |
Member
|
This is a pretty nice improvement, good idea @beardypig. |
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
logging: fixed issue with logging from plugins using logging module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously plugins would be loaded with the module name set to the plugin name, eg.
twitch, this PR changes that so that plugins are loaded within thestreamlink.pluginhierarchy.I also tweaked the way that the plugin load setup is called (I am slowly chipping away at the global variables). There is also now a debugging log message when a plugin is overridden by an external plugin file - this should help us when debugging issues with plugins, in case the user is using a non-standard plugin version.