api.utils: hours_minutes_seconds update, twitch automate time offset#1804
Conversation
|
Looks good to me. I restarted the Travis job, it failed due to network errors on their side. |
Codecov Report
@@ Coverage Diff @@
## master #1804 +/- ##
==========================================
+ Coverage 50.15% 50.22% +0.07%
==========================================
Files 235 236 +1
Lines 13978 13988 +10
==========================================
+ Hits 7011 7026 +15
+ Misses 6967 6962 -5 |
|
Maybe this is better in |
|
should it be in a newfile |
|
I was debating that with myself too... I'm not sure, maybe nicer to have a separate file :) Which do you prefer? |
|
I would go with a separate file |
|
Agreed. |
**hours_minutes_seconds**: allow more timestamps - hours:minutes:seconds to seconds - 11h22m33s to seconds - 11h to seconds - 20h15m to seconds - seconds to seconds **twitch**: - automate hls-start-offset for urls with timestamps - update for the old vod url's, which I don't think exist anymore **youtube**: - tested on youtube, but did not add it because there are to many http streams
|
moved it into a new file |
beardypig
left a comment
There was a problem hiding this comment.
I might have separated the tests a bit so you get a bit more info if they fail, but it makes little difference.
|
@gravyboat this is good to go. |
|
Looks good, thanks @back-to! |
api.utils: hours_minutes_seconds update, twitch automate time offset
hours_minutes_seconds:
allow more timestamps
twitch:
hls-start-offsetfor urls with timestampsyoutube:
I put it into
api/utils.pybut could also move it somewhere else.will break #1792 as it uses the same file