Codecov Report

Merging #1853 into master will decrease coverage by 0.01%.
The diff coverage is 31.25%.

@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
- Coverage   50.39%   50.37%   -0.02%     
==========================================
  Files         239      239              
  Lines       14078    14085       +7     
==========================================
+ Hits         7095     7096       +1     
- Misses       6983     6989       +6

Looks good, thanks @beardypig.

Hello,

When trying something like this URL with this new plugin :
Streamlink.exe https://www.atresplayer.com/antena3/series/la-catedral-del-mar/clips/primer-trailer-oficial-de-la-catedral-del-mar_5ae8af4d986b28f26ee8fcca/ Best

It returns the 720p stream but there is no sound on it apparently, it says it's the "720p ( HLS-Multi )" not the "Dash" stream.

Checking the list of streams there is this :
Available streams: 720p+a128k, 480p+a128k, 360p+a128k, 240p+a128k, 240p (worst), 360p, 480p, 720p (best)

If using streamlink URL 720p+a128k we get the dash stream with sound this time.

Problem is that i use Streamlink with a generic batch script having various options but Best is set by default as a permanent setting.

So i tried to make a Plugin specific configuration file "streamlinkrc.atresplayer" with this inside :

default-stream=720p+a128k

But the plugin specific settings files do not override the initial command line, I'm not sure if it's intended or not but could never get them to bypass initial command.

Trying also with only stream-priority=dash in config file but then there is no "Best" stream for this one...

Let's say initial command is Streamlink URL best and plugin specific config files "streamlinkrc.plugin" have things like
default-stream=worst or here default-stream=720p+a128k (or whatever command already present in the initial command line like --player="xxx" etc etc ), then it's always the initial command that is taken, never the plugin specific config file, here the "Best" setting gets the priority.

The plugin specific settings never override this, again i'm not sure if it's normal or not or even possible to override one setting sent in the first command if also present in the specific plugin config file, which should get the priority and be the logical thing, at least on my mind it is, if needed i'll make a request for this so please let me know if normal or not of is a request can be done so the specific plugin configuration files settings can always get the priority above the rest.

Anyways, i don't know if it's possible or if it makes sense but maybe Best or Worst labelled streams should be the ones having the sound, 720p+a128k or 240p+a128k for now.

Thank you very much.

Ps: i can't test for geo restricted videos there as currently not having the possibility to try with a Spanish IP right now, so i don't know if the streams work the same for other stuff, i mean if the list of available steams is labelled the same.

Thanks again for all you do guys :)

PS: there seems to be another issue here, the URL when used in dash streams 720p+a128k, 480p+a128k etc never goes to the end, it seems stops around 1mn15s or so but duration is 2mn02, works fine when using streams like 720p, 480p, worst, best etc, but no sound there... Not sure if this one is on my end only or server having issues tho.

@jalba69 I will take a look. In the meantime, you can use the option --stream-types dash to only return DASH streams and choose "best" quality.

Hello,

I tried this option too but it returns me that there is no best streams when using this option.
error: The specified stream(s) 'Best' could not be found. Available streams: 720p+a128k, 480p+a128k, 360p+a128k, 240p+a128k

same for stream-priority=dash
Thank you.

@jalba69 you're right, there is a bug there :) I'll create a fix for that.

The HLS stream plays fine for me using ffmpeg 4.0.1 (ffmpeg is used for hls-multi) but it does not play using ffmpeg 2.8.14. It seems there is an issue with the audio stream. Unfortunately this isn't something we can fix. If you can, try using a newer version of ffmpeg, or stick the to the DASH streams.

Good to hear :)
I use latest Zeranoe build of FFmpeg , no dice with the 4 players i tested , mpc-hc, mpc-be, vlc and ffplay.

I could use Dash stream if there was a way for the specific plugin config files to bypass any other parameters like i was explaining but here as long as Best is set in the initial command the rest from the config file is ignored instead of taking the priority if they exist, doesn't seems logical and not sure if it's intended or not but I'll probably create a separate thread asking for this one i think.

Thank again for all.

ffiw, I was using mpv 0.28.2 :)

Tried a version of MPV ( 0.28.0 / Nightly 20180624 (June 24, 2018) , did not found 0.28.2 for windows after a very quick search ) and it seems like it works somehow... but there is a huge delay before starting to play, a bit like if it was getting both video + audio downloaded then serving it muxed to the player.

Spent quite some time banging my head against the wall trying various things and then grabbed directly the "Best" hls-multi file to analyze it a bit, mediainfo reports audio + video tracks but my usual players can't read audio on it...

FFplay reports this :

Will try with suggestions for analyzeduration & probesize on the message later at night...

Tried to demux the audio track using MP4box, got an error message,
[iso file] Unknown box type .B.% [iso file] Incomplete box UNKN [iso file] Incomplete file while reading for dump - aborting parsing [iso file] Unknown box type .B.% Truncated file - missing 1138843956 bytes Error opening file H:\vid.mp4: IsoMedia File is truncated

Then used eac3to.exe to get audio track, this time it worked but on the log i get this :
[a02] The last AAC frame is incomplete and thus gets skipped. <WARNING>

Once demuxed i can load external audio track obtained on top of video and it works but seems like something is messed up with streams... and with my eternal good luck i picked the very best link to try this plugin, sorry for that :/

Well, at least 720p+a128k, 480p+a128k etc will be parsed now if i understood the changes you done so it's not a total waste (i hope).

Noticed there is also 1080_dash, 720_dash etc on some other videos but using "Best" combined with stream-priority=dash located inside streamlinkrc.atresplayer config file seems to work and deliver the dash file correctly so i guess you already had this covered :)

Thanks a lot for your help and work on this.

Now i need a a little break and i'll ask later in a dedicated thread about the plugins specific configuration files and why they do not take the priority above the other settings and if something is possible to be done for that so the parameters inside those plugin settings files always get top priority even if the parameter have already been set to the command or is present in the general streamlinkrc settings file and will apologize for bothering you guys ^^

Thank you very much ;)