Fix 404 error on twitch oauth authorize url#1856
Merged
gravyboat merged 1 commit intoJun 27, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
======================================
Coverage 50.5% 50.5%
======================================
Files 239 239
Lines 14130 14130
======================================
Hits 7136 7136
Misses 6994 6994 |
beardypig
approved these changes
Jun 26, 2018
beardypig
left a comment
Member
There was a problem hiding this comment.
Good catch, thanks @NyanKiyoshi :)
Member
|
Thanks @NyanKiyoshi! |
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
…authorize-url Fix 404 error on twitch oauth authorize url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the 404 error when user request a oauth token for Twitch by removing the trailing slash from the endpoint.
How to reproduce
streamlink --twitch-oauth-authenticate