Current coverage is 33.80% (diff: 100%)

Merging #250 into master will not change coverage

@@             master       #250   diff @@
==========================================
  Files            43         43          
  Lines          5457       5457          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1845       1845          
  Misses         3612       3612          
  Partials          0          0          

Powered by Codecov. Last update 96a6a95...efbe7f7

This looks fine to me, have you guys finished all the testing you want to do?

Having trouble building the binary for this. If @beardypig could share a the installer built with this script I will test it in the Chocolatey environment.

Sure I'll build one in a bit a link to it in the top post.

@scowalt I have added a link to a build of the installer in the first post :)

Looks like I still get the same error after running the executable and restarting the machine:

My only thought is that the vcredist2015 chocolatey package seems to install some windows updates that could be important in getting everything to run.

Either way, I'm not sure how much you want to block on this. I could always add vcredist2015 to the dependencies in the Chocolatey package. This would potentially cause us to contribute to the VC++ wall of doom, but at least we'll know it's working for everyone:

OK @scowalt, maybe the x64 installer does need to be included as well... I will try some stuff on the chocolatey test env :)

Yeah, sounds like you also need some Windows update for Server 2012 and Windows 8.1 for it to work...

@scowalt I'd go with adding vcredist2015 as a dependency to the Chocolatey package. This could turn in to a bit of rabbit warren, with Windows updates, etc.

It might just be better to tell people they need to install the VC 2015 Runtimes and make sure all the Windows updates are installed.

What about if we give a warning yes/no dialog before the installer if the VC2015 runtimes are not installed? Something like:

Visual C++ Runtime x86 is required! Streamlink will not work without it. Do you still wish to continue?

I'll add vcredist2015 as a Chocolatey dependency.

I'm fine with a pre-install warning. Maybe a link to the runtime if we're not going to bundle it? Also, listing it as a requirement in the README would be nice.

I would just confirm that whatever warning you add will still allow the installation to run silently. I'm running the installer silently using the command <installer>.exe /S. See https://github.com/streamlink/streamlink-chocolatey/blob/master/Streamlink/tools/chocolateyinstall.ps1#L19

I feel pretty dumb as pynsist actually supports this ... 😓

I have updated the installer script, and also the docs to say that XP is not supported 😃

Wouldn't it be better to use [% extends "pyapp_msvcrt.nsi" %] at the head of our custom template instead of [% extends "pyapp.nsi" %]?
https://github.com/streamlink/streamlink/blob/0.1.0/script/makeinstaller.sh#L58
https://github.com/takluyver/pynsist/blob/1.9/nsist/pyapp_msvcrt.nsi#L1
This way you don't need to copy its content.

@bastimeyer didn't work when I tried it...

Must have been a temporal anomaly, cos it works fine now .... :|

@scowalt I've updated the installer in the top post, and I tested it on the Chocolatey vagrant machine and it worked as expected. Do you want to give it a go.

I think this is good to merge unless anyone has any objections :-)

@beardypig I'm fine with it, I'll leave it unmerged for a bit in case there are any other comments, if not I'll merge it tonight.

No objections? It seems to work, see #255 and #267.

Thanks @beardypig!

@beardypig Is Visual Studio 2015 Runtime included in the nightly builds?

Thanks for getting this done @beardypig!

This will get picked up in Chocolatey when the executable gets built for the next release (0.1.1 or 0.2.0 😄). Until then, I have a Chocolatey package in the moderation queue that adds vcredist2015 as a dependency.

@thinkpad4 sure is, did you have a problem with it?

@beardypig Nope just making sure. Thanks

@Rosadintv for your portable installer, you might need to add the UCRT DLLs (if you don't already, I'm not sure if you do), so that users don't run in to the same problem when they don't have KB2999226 (Windows 10 Universal C Runtime) installed.

@beardypig If i use your "streamlink\python" folder is right? (I see it contains api-ms-xx dll's)

@Rosadintv there are two zip files in the repo that you can use, an x86 one and an x64 one, it might be cleaner for you to use those :-)

@beardypig I will use the x86 one, thanks ❤️