plugins.crunchyroll: update auth logic#3150
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3150 +/- ##
==========================================
- Coverage 52.66% 52.63% -0.04%
==========================================
Files 244 244
Lines 15623 15631 +8
==========================================
- Hits 8228 8227 -1
- Misses 7395 7404 +9 |
1 task
Member
|
Nice looks good, thanks @beardypig. |
|
Thanks @beardypig. Confiring this fixes the issue - I had to still manually delete my auth token file to get it to work though. |
Member
Author
|
@skcihmit that's weird, it should have detected that the credentials didn't work and removed them automatically. You don't happen to have a log output from that failed attempt do you? :) |
|
@beardypig sorry, no I don't, and I can't recreate it, so must have been something else I did. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the auth logic a bit, re-authenticating with the auth token no longer returns an auth token. If the saved token no longer works then it will try to authenticate with the username and password if they are set.
I updated the old logging calls too.
fixes #3148