seems a bit over the top for a project like Streamlink.

This will make reviewing docs changes way more easy.

you already have all the new files when you are testing the PR,
building it locally isn't a big problem.

if you don't want to build it, just review it after the merge
as this is still a in development branch which can be changed easily.

https://streamlink.github.io/latest/
https://github.com/streamlink/streamlink.github.io

a bit over the top for a project like Streamlink
building it locally isn't a big problem.

And it's always annoying and has not been done by the reviewer(s) most of the time anyway so far. Having the docs built and hosted for everyone to see and review, even the PR author, is an improvement and it encourages making improvements to the docs. Only one always passing PR status check gets added to PRs, and only to those with actual changes to the docs, so there's no need to worry about spam.

I would very much like to give this a try at least. If there are major problems, the integration can be removed again.

If you want, we can wait until the 2.0.0 release, so that it doesn't cause unnecessary noise.

Now to their answer to my questions. They said that having a CoC is mandatory, but having a simple/minimal one is acceptable. Adding a small link somewhere on the index page for the second requirement is enough.

Not sure if you guys agree with this though. As said, I don't have a problem with these two requirements, but if one does, we could go with the free account as well.

My CoC suggestions are this:

1. https://github.com/domgetter/NCoC/blob/master/CODE_OF_CONDUCT.md
2. https://github.com/dorssel/usbipd-win/blob/d68b39d4af46288eb4601dd4ecf77643f0adf91a/CODE_OF_CONDUCT.md (the only version of this I found on Github)
3. Or a simplified/shortened version of 2

The link diff could look like this:

diff --git a/docs/index.rst b/docs/index.rst
index 530b643a..bf1c254a 100644
--- a/docs/index.rst
+++ b/docs/index.rst
@@ -75,3 +75,9 @@ See their respective sections for more information on how to use them.
     donate
     applications
     thirdparty
+
+Thank you
+---------
+
+- `Github <https://github.com/>`_
+- `Netlify <https://www.netlify.com/>`_

@bastimeyer Thanks for getting the details back from them. I'm in favor of CoC 2 or a slightly shortened version, and the doc link is fine since it's only on the index and only text.

Can we give this a go then? We've already merged the CoC without even adding the netlify integration here. As said, this config is required before I can add the integration, as it would otherwise run production builds on pushes onto the master branch.

What I've also noticed is that the ignore option currently doesn't catch any changes to PluginArguments. That's a bit difficult to catch in a git diff though. All that could be done is increasing the diff size and checking the output for PluginArgument, eg. like this git diff -U8 | grep PluginArgument, but it would catch unrelated changes too.

Can we give this a go then?

Let's do it!

I've added the netlify integration to the repo and opened #3463 where you can see the docs preview in the PR status check list.

I'm going to open another PR with the thank you note and will reference the PR link in the application form.