utils/l10n: fix langs without alpha_2 in pycountry#3518
Merged
Conversation
|
I applied this patch to both |
Member
|
Looks good @bastimeyer, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3517
languages.lookupcall with severallanguages.get(attr=language)calls, whereattrisalpha_2,alpha_3,bibliographicandname, in this order. Other attributes are probably not relevant for Streamlink..getcalls don't raise and just returnNoneif the lookup fails. The order of attribute lookups prevents issue utils.l10n: fix pycountry language lookup #3057, wherelanguage.lookup("en")would return the "En" language instead of "English".AttributeErrorfrom being raised when certain optional language attributes are missing, likealpha_2for example, those will be read viagetattrwith an empty string as fallback (instead ofNone), which matches the data representation ofiso639.alpha_3andnameattributes always exist.{ "alpha_3": "des", "name": "Desano", "scope": "I", "type": "L" }