build: include removed plugins file in sdist#3644
Merged
bastimeyer merged 1 commit intoMar 23, 2021
Merged
Conversation
Member
Author
$ curl -sSL 'https://github.com/streamlink/streamlink/releases/download/2.1.0/streamlink-2.1.0.tar.gz' \
| tar -tzf - \
| grep src/streamlink/plugins/.removed
$ git checkout 2.1.0 && python setup.py sdist
$ tar -tzf dist/streamlink-2.1.0.tar.gz \
| grep src/streamlink/plugins/.removed
streamlink-2.1.0/src/streamlink/plugins/.removed |
Member
Author
|
According to
the file shouldn't be in the tarball unless explicitly specified, which totally makes sense, but I don't understand why it's included when I build it locally on my system using the same python version and using a clean venv. Weird. Just for the record, #3643 has only become a problem due to #3600 and the added test, which made the file a dependency for running tests. |
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Mar 24, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Mar 26, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Mar 26, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Mar 26, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3643
For some reason, the
src/streamlink/plugins/.removedfile is not part of the sdist tarball in2.1.0.This PR forces the inclusion of that file via
MANIFEST.in.I don't know why, but when I build
2.1.0locally, the file is part of the tarball, but the one built by the CI runner does not include it. Can someone confirm this?