plugins.picarto: rewrite/fix#3661
Merged
Merged
Conversation
bastimeyer
reviewed
Apr 1, 2021
bastimeyer
left a comment
Member
There was a problem hiding this comment.
I don't have the time to review this now, but the websocket logic needs to be refactored at some point. For anything HTTP related we have the HTTPSession, but the websocket stuff gets duplicated here for the fourth time, and this is a problem.
Member
Author
|
OK. I guess the WS stuff is just something to be added to the TODO list at some point in the future... |
back-to
reviewed
Apr 2, 2021
28bac20 to
66d9976
Compare
back-to
reviewed
Apr 4, 2021
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Apr 6, 2021
Co-authored-by: back-to <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3647