plugins.youtube: translate embed_live URLs#3804
Merged
back-to merged 1 commit intoJun 20, 2021
Merged
Conversation
- translate embedded live-channel URLs to avoid unnecessary HTTP redirections and having to find the canonical URL in the metadata - add URL translation tests - fix plugins can_handle_url pytest collection function
5498800 to
c53181f
Compare
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Jun 20, 2021
- translate embedded live-channel URLs to avoid unnecessary HTTP redirections and having to find the canonical URL in the metadata - add URL translation tests - fix plugins can_handle_url pytest collection function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redirections and having to find the canonical URL in the metadata
In regards to #3797 (comment), channel URLs like
youtube.com/CHANNELNAMEoryoutube.com/channel/CHANNELIDcould be translated toyoutube.com/CHANNELNAME/liveoryoutube.com/channel/CHANNELID/liverespectively, but that would also require a change of the logic when the embedded data is missing, eg. when a channel is not live, and it'd have to always raise aNoStreamsErrorinstead of aPluginErrorfor a more graceful error message, which would be misleading in some cases.