plugins.youtube: Better API age-gate bypassing#4058
Merged
Conversation
Member
Doesn't seem to work
Doesn't work either |
Based on yt-dlp/yt-dlp#574 (comment) - Works in videos like https://www.youtube.com/watch?v=Tq92D6wQ1mg - embedUrl is required for videos like https://www.youtube.com/watch?v=HsUATh_Nc2U but I can't find any examples that aren't protected so I left it out - Still doesn't work for videos like https://www.youtube.com/watch?v=Cr381pDsSsA which seem to have embedding explicitly disabled (since it returns an `Playback on other websites has been disabled by the video owner.` error)
a9e8ee1 to
feadc7c
Compare
Contributor
Author
|
@bastimeyer I'm so sorry, I thought I already changed it before pushing 😅 It should be fixed now |
Member
|
This works, but there's an unnecessary error log message which needs to be fixed. This is caused by the A bit messy and not ideal, but this should do: diff --git a/src/streamlink/plugins/youtube.py b/src/streamlink/plugins/youtube.py
index 0d4de670..1a9ea804 100644
--- a/src/streamlink/plugins/youtube.py
+++ b/src/streamlink/plugins/youtube.py
@@ -279,12 +279,13 @@ class YouTube(Plugin):
if videoId is not None:
return videoId
- def _data_status(self, data):
+ def _data_status(self, data, errorlog=False):
if not data:
return False
status, reason = self._schema_playabilitystatus(data)
if status != "OK":
- log.error(f"Could not get video info - {status}: {reason}")
+ if errorlog:
+ log.error(f"Could not get video info - {status}: {reason}")
return False
return True
@@ -303,7 +304,7 @@ class YouTube(Plugin):
data = self._get_data_from_regex(res, self._re_ytInitialPlayerResponse, "initial player response")
if not self._data_status(data):
data = self._get_data_from_api(res)
- if not self._data_status(data):
+ if not self._data_status(data, True):
return
video_id, self.author, self.title, is_live = self._schema_videodetails(data) |
Member
|
@MinePlayersPE could you please add the diff I've posted to your changes, so that the incorrect log message can be fixed? |
Contributor
Author
@bastimeyer Done! 👍 I thought by |
Member
|
Thanks |
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Oct 2, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on yt-dlp/yt-dlp#574 (comment)
Playback on other websites has been disabled by the video owner.error)