stream.http: fix custom method argument#4171
Merged
Merged
Conversation
b34f84f to
4450674
Compare
4450674 to
f201960
Compare
Member
Author
|
master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #4169, the method parameter was not working.
I've also changed
valid_args()and hardcoded the supported args, becauserequests.Request()andrequests.Session.request()don't share the same set of args and some args should not be set by the user anyway.No tests, because there are no HTTPStream tests, and I don't want to add new ones. You can check the output of
--jsoninstead.