installer: set pynsist to 2.7 and distlib to 0.3.3#4308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4307
According to my locally built installers, downgrading distlib to 0.3.3 fixes the issue of the broken executables. This is not a long-term solution, but it should work for now.
I'd like to publish 3.1.1 as soon as possible, but I also want to see if the next nightly is working as intended once this gets merged.
As said in #4307, the executables are only broken when trying to run them from a non-command-line context on Windows, eg. from a GUI application and they immediately terminate with exit code 3221225477. I don't know how the executables work. I only know how pynsist concatenates the binaries built by the distlib project with a shebang and the application's entry script.