Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: update windows binaries section#4581

Merged
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:docs/windows-builds
Jun 12, 2022
Merged

docs: update windows binaries section#4581
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:docs/windows-builds

Conversation

@bastimeyer

Copy link
Copy Markdown
Member

Resolves #4579


This removes beardypig's portable builds from the docs, reformats the windows binaries section and it updates the links/anchors at the top (the sub-sections got renamed).

@bastimeyer

Copy link
Copy Markdown
Member Author

@bastimeyer bastimeyer requested a review from gravyboat June 12, 2022 03:03
@bastimeyer bastimeyer force-pushed the docs/windows-builds branch from d306fad to bea495a Compare June 12, 2022 03:12

@gravyboat gravyboat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bastimeyer. Minor question around whether links should go directly to the releases page or not, but I'm marking this as approved. If you disagree merge whenever.

Comment thread docs/install.rst

Since late March 2022, Windows installers for Streamlink can be found at the `streamlink/windows-installer`_ repository
on GitHub, with support for different architectures and different Python versions.
Windows installers and portable builds for Streamlink can be found at `streamlink/windows-builds`_,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link to the releases page? Maybe I'm over thinking it but some people may get confused by not knowing where to go from this link or the others above.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention was to only link to the releases page in the "stable" subsection below because of the distinction between stable and nightly builds. This here should therefore just link to the repo. The repo's readme also links to the releases page.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@gravyboat gravyboat merged commit 2a5b71f into streamlink:master Jun 12, 2022
@bastimeyer bastimeyer deleted the docs/windows-builds branch June 12, 2022 06:34
@WolfganP

WolfganP commented Jul 9, 2022

Copy link
Copy Markdown

I tested the new portable win 4.20 release and works OK. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Windows portable archives

3 participants