release: 4.2.0#4639
Conversation
|
Changelog looks good. Let's wait on those last few PRs before we cut this though.
I don't think a deprecation notice is needed. We're really just matching newer standards. |
71e25fb to
ca0f6ac
Compare
|
@bastimeyer I think everything that needs to get in should be in, the vimeo update would be nice to have but I don't think that's ready. Anything else you want to get in before I merge this and cut the release? |
|
Given that the Vimeo issue has been open for a year and half, it probably doesn't matter if it doesn't go into this release, although as you say, it would be nice. The other thing about that PR is not only the Vimeo plugin itself, but whether or not the changes in I will try and get back to it shortly in any case. |
|
@mkbloke Definitely not a big deal so don't inconvenience yourself, it's just the only PR currently open that will be merged at some point. |
|
#4643 should be merged before 4.2.0 gets released. |
|
@bastimeyer #4643 is in. |
ca0f6ac to
1ac68b8
Compare
|
Why was the "New release" step skipped? |
|
That's the run condition: streamlink/.github/workflows/main.yml Line 113 in 3ce3694 The only recent change was this, but that shouldn't be relevant, as the workflow was already triggered: streamlink/.github/workflows/main.yml Lines 5 to 6 in 3ce3694 |
|
Ok, none of the action workflow runs was triggered by the tag-push. Tag Why is it saying that I tagged it? I didn't... |
|
Since I don't know what you did and what happened exactly, @gravyboat, I will delete the tag now and push a new one. |
|
So apparently, the
|
|
@bastimeyer For future reference when I tag all I do is pull the latest down, |
Preliminary changelog with the release date set for tomorrow, but as usual, nothing is set in stone here.
Please check for any mistakes or if something important is missing.
There are still a few PRs/issues open, so it might make sense waiting a bit more.
Regarding the changes of #4568, the
url_masterparameter ofHLSStreamandMuxedHLSStreamwas deprecated in favor ofmultivariant, but no proper deprecation was added to the docs, and only the parameter docstrings were updated. Is that something you think should be added to the doc's deprecations page?