Thanks to visit codestin.com
Credit goes to github.com

Skip to content

release: 4.2.0#4639

Merged
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:releases/4.2.0
Jul 9, 2022
Merged

release: 4.2.0#4639
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:releases/4.2.0

Conversation

@bastimeyer

Copy link
Copy Markdown
Member

Preliminary changelog with the release date set for tomorrow, but as usual, nothing is set in stone here.

Please check for any mistakes or if something important is missing.

There are still a few PRs/issues open, so it might make sense waiting a bit more.


Regarding the changes of #4568, the url_master parameter of HLSStream and MuxedHLSStream was deprecated in favor of multivariant, but no proper deprecation was added to the docs, and only the parameter docstrings were updated. Is that something you think should be added to the doc's deprecations page?

@gravyboat

gravyboat commented Jul 7, 2022

Copy link
Copy Markdown
Member

Changelog looks good. Let's wait on those last few PRs before we cut this though.

the url_master parameter of HLSStream and MuxedHLSStream was deprecated in favor of multivariant, ...

I don't think a deprecation notice is needed. We're really just matching newer standards.

@bastimeyer bastimeyer force-pushed the releases/4.2.0 branch 2 times, most recently from 71e25fb to ca0f6ac Compare July 8, 2022 00:01
@gravyboat

Copy link
Copy Markdown
Member

@bastimeyer I think everything that needs to get in should be in, the vimeo update would be nice to have but I don't think that's ready. Anything else you want to get in before I merge this and cut the release?

@mkbloke

mkbloke commented Jul 8, 2022

Copy link
Copy Markdown
Member

Given that the Vimeo issue has been open for a year and half, it probably doesn't matter if it doesn't go into this release, although as you say, it would be nice.

The other thing about that PR is not only the Vimeo plugin itself, but whether or not the changes in stream.hls that are required for the Vimeo plugin fix are fully decided upon also.

I will try and get back to it shortly in any case.

@gravyboat

Copy link
Copy Markdown
Member

@mkbloke Definitely not a big deal so don't inconvenience yourself, it's just the only PR currently open that will be merged at some point.

@bastimeyer

Copy link
Copy Markdown
Member Author

#4643 should be merged before 4.2.0 gets released.

@gravyboat

Copy link
Copy Markdown
Member

@bastimeyer #4643 is in.

@gravyboat gravyboat merged commit 3ce3694 into streamlink:master Jul 9, 2022
@bastimeyer bastimeyer deleted the releases/4.2.0 branch July 9, 2022 02:44
@bastimeyer

Copy link
Copy Markdown
Member Author

Why was the "New release" step skipped?
https://github.com/streamlink/streamlink/runs/7260805016

@bastimeyer

Copy link
Copy Markdown
Member Author

That's the run condition:

if: github.repository == 'streamlink/streamlink' && github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')

The only recent change was this, but that shouldn't be relevant, as the workflow was already triggered:

branches-ignore:
- 'automated/**'

@bastimeyer

Copy link
Copy Markdown
Member Author

Ok, none of the action workflow runs was triggered by the tag-push.
https://github.com/streamlink/streamlink/actions

Tag 4.2.0 exists though:
https://github.com/streamlink/streamlink/releases/tag/4.2.0

Why is it saying that I tagged it? I didn't...

@bastimeyer

Copy link
Copy Markdown
Member Author

Since I don't know what you did and what happened exactly, @gravyboat, I will delete the tag now and push a new one.

@bastimeyer

Copy link
Copy Markdown
Member Author

So apparently, the branches-ignore list is responsible for this:
https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-filters-to-target-specific-branches-or-tags-for-push-events

If you define only tags/tags-ignore or only branches/branches-ignore, the workflow won't run for events affecting the undefined Git ref. If you define neither tags/tags-ignore or branches/branches-ignore, the workflow will run for events affecting either branches or tags.

@gravyboat

gravyboat commented Jul 9, 2022

Copy link
Copy Markdown
Member

@bastimeyer For future reference when I tag all I do is pull the latest down, git tag x.x.xx then git push origin x.x.xx. Nothing fancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants