Remove plugins: nbc, nbcsports, theplatform#4731
Merged
back-to merged 3 commits intoAug 12, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nbcandnbcsportsplugins appear to be broken. They are both wrappers for thetheplatformplugin, implemented in a bad way. These plugins are VOD-only plugins, so there's no real incentive to fix them unless someone deems them as important. Since there haven't been any recent bug reports, I think removing them is fine.The available live content on nbc.com is covered by nbcnews.com/now via the nbcnews plugin. Other live content requires authentication via US internet providers. And live content on nbcsports.com is hosted on different sites from what it looks like.
The VODs on nbc.com and nbcsports.com that are supposed to work via the
theplatformplugin could be re-implemented in a new single plugin that matches both sites. Having three separate plugins where two basically share the exact same code doesn't make sense and I don't think there should be a dedicated plugin for player.theplatform.com which requires obscure stream URLs.