Thanks to visit codestin.com
Credit goes to github.com

Skip to content

plugins: fix regex capture groups#4770

Merged
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/fix-regex-capture-groups
Aug 26, 2022
Merged

plugins: fix regex capture groups#4770
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/fix-regex-capture-groups

Conversation

@bastimeyer

Copy link
Copy Markdown
Member

Fixes #4769

These changes are based on the diff of #4702, where plugins and their validation schemas were refactored. In some plugins, I modified some regexes and added named capture groups for back-references of quotations, but forgot to change the index of the capture group getter. This change replaces the indexed getter with a named one, to avoid this.


$ streamlink 'https://rotana.net/live-clip'
[cli][info] Found matching plugin hiplayer for URL https://rotana.net/live-clip
Available streams: 240p (worst), 360p, 480p, 720p, 1080p (best)
$ streamlink 'https://www.cnbcarabia.com/Pages/live'
[cli][info] Found matching plugin hiplayer for URL https://www.cnbcarabia.com/Pages/live
Available streams: 240p (worst), 360p, 480p, 720p (best)
$ streamlink 'https://www.media.gov.kw/LiveTV.aspx?PanChannel=KTV1'
[cli][info] Found matching plugin hiplayer for URL https://www.media.gov.kw/LiveTV.aspx?PanChannel=KTV1
Available streams: 240p (worst), 360p, 480p, 720p, 1080p (best)

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Aug 26, 2022
@gravyboat gravyboat merged commit 5c8715f into streamlink:master Aug 26, 2022
@bastimeyer bastimeyer deleted the plugins/fix-regex-capture-groups branch August 26, 2022 19:08
@UltraHDR

Copy link
Copy Markdown
Contributor

Thankyou very mush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugins.hiplayer not working

3 participants