plugins.bloomberg: update/fix headers to avoid bot detection#4919
Merged
Conversation
Member
Brotli does only get added by urllib3 if the
The bot detection triggers regardless whether brotli is available or not, just checked it. No idea why removing the header works... 😕 |
4 tasks
Member
Author
|
Ah, I just read your comment here after writing: #4918 (comment) Well, that's very strange indeed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as my testing goes, all the previously added headers seem to be unnecessary. Adding the
Accept-Encodingheader back seems to trigger bot detection, possibly because with requests it only includesgzipanddeflate, but notbr, which Firefox also includes. Removing the header entirely seems to work.closes #4918