plugins.tvp: fix channel ID lookup#4997
Merged
Merged
Conversation
Contributor
|
It seems to be working fine, I could not test the VOD but for the live I did get the playlist. Thank you |
Contributor
|
I seem to get the wrong qualities 720 and 1080 are missing |
- Fix channel ID lookup - Fix validation schema on missing data - Add more stream types to live streams: HTTPStream for content restriction clips, and DASHStream where HLS is not available - Apply minor code refactoring
9e1d90d to
c5e3370
Compare
Member
Author
|
Some channels appear to have multiple entries for hls streams with the first one having all qualities available. Since the order of other stream types in the whole response data is not guaranteed and the streams can't be iterated in the returned order, I had to implement a kinda awkward workaround, so that it always gets HLS streams first. Should be working fine now. |
Contributor
|
Yes, it works fine now. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4996
I didn't check anything VOD related...
@HappyPlotter could you please test and verify these changes? Thanks.