chore: ignore coverage in TYPE_CHECKING blocks#5092
Merged
bastimeyer merged 1 commit intoJan 14, 2023
Conversation
Member
Author
|
Btw, codecov is once again showing complete nonsense data, both for PRs and for the master branch (which is outdated). 🤦♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally forgot to suppress coverage of the
TYPE_CHECKINGblock added in #5090.https://app.codecov.io/gh/streamlink/streamlink/pull/5090
This PR adds
TYPE_CHECKINGto the list of excluded lines viapyproject.toml. But since pycharm seems to ignore this when building coverage reports via thecoveragemodule, I also added the regular# pragma: no coverdirective.