Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build: include icon.svg in sdist#5119

Merged
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:build/icon-in-manifest
Jan 25, 2023
Merged

build: include icon.svg in sdist#5119
gravyboat merged 1 commit into
streamlink:masterfrom
bastimeyer:build/icon-in-manifest

Conversation

@bastimeyer

@bastimeyer bastimeyer commented Jan 25, 2023

Copy link
Copy Markdown
Member

For some reason, the icon.svg file was never added to the sdist manifest file, which meant the icon file was only included by accident in the docs dir, from the symlinked icon in the _static subdirectory. Let's fix this.

$ curl -sSL 'https://files.pythonhosted.org/packages/9e/0c/b8c90cda86583a141dcc584eb32838ed312fb8cd9d5aab20faaa7f49d5fb/streamlink-5.2.1.tar.gz' \
  | bsdtar -tf - \
  | grep -E '^streamlink-.+/icon.svg'
streamlink-5.2.1/docs/_static/icon.svg
$ python -m build --sdist >/dev/null 2>&1
$ bsdtar -tf dist/streamlink-5.2.1+1.gb5d5a042.tar.gz \
  | grep -E '^streamlink-.+/icon.svg'
streamlink-5.2.1+1.gb5d5a042/docs/_static/icon.svg
streamlink-5.2.1+1.gb5d5a042/icon.svg

@gravyboat gravyboat merged commit 317dc8e into streamlink:master Jan 25, 2023
@bastimeyer bastimeyer deleted the build/icon-in-manifest branch January 26, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build config

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bastimeyer @gravyboat