stream.ffmpegmux: fix copy-to-pipe race condition#5162
Merged
gravyboat merged 2 commits intoFeb 14, 2023
Conversation
Make sure that each substream's buffer always gets fully emptied when closing the stream, so that no data is missing when muxing the output stream. TODO: properly refactor FFMPEGMuxer class with full test coverage
213ebd6 to
c4f7e80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that each substream's buffer always gets fully emptied when closing the stream, so that no data is missing when muxing the output stream.
TODO: properly refactor FFMPEGMuxer class with full test coverage
Fixes #5159
The second commit fixes another race condition in the
NamedPipePosiximplementation when attempting to close the file descriptor of a broken named pipe where the fifo wouldn't get unlinked in the filesystem.As mentioned in #5159 (comment), I will have a look at properly refactoring/rewriting the
FFMPEGMuxerclass some time later.Pipe-copying now ends simultaneously and no data should be missing in the muxed output stream: