stream.dash: fix SegmentTemplate's BaseURL context#5194
Merged
gravyboat merged 1 commit intoFeb 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4586
Previously, when formatting init/media segment URLs of a
SegmentTemplate, its own inheritedbase_urlproperty was used, which does only work in MPD documents where the nextBaseURLnode is a child node of one of theSegmentTemplate's ancestor nodes, namelyAdaptationSet,PeriodorMPD:This left out potential
BaseURLchild-nodes inRepresentationnodes that are siblings ofSegmentTemplate(and similar cases):To fix the issue, just pass the resolved
base_urlfrom theRepresentationinstance to theSegmentTemplate's segment generator, where the init/media URLs are formatted.