stream.dash: fix suggestedPresentationDelay#5215
Merged
gravyboat merged 1 commit intoMar 4, 2023
Merged
Conversation
- Convert `isodate.Duration` instances to `datetime.timedelta` in `SegmentTemplate.format_media()` in order to be able to compare with `datetime.datetime` in the timeline generator - Keep `isodate.Duration` or `datetime.timedelta` instances in `SegmentTemplate.segment_numbers()` before subtracting from `since_start`, as `isodate.Duration()` can't be converted to seconds without a reference `datetime.datetime` - Replace all `isodate.Duration()` attribute default values with `datetime.timedelta()` for simplicity/performance reasons - Set the 3 seconds default value of `MPD.suggestedPresentationDelay` on the attribute's default definition instead of using constants in the `SegmentTemplate` methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isodate.Durationinstances todatetime.timedeltainSegmentTemplate.format_media()in order to be able to compare withdatetime.datetimein the timeline generatorisodate.Durationordatetime.timedeltainstances inSegmentTemplate.segment_numbers()before subtracting fromsince_start, asisodate.Duration()can't be converted to seconds without a referencedatetime.datetimeisodate.Duration()attribute default values withdatetime.timedelta()for simplicity/performance reasonsMPD.suggestedPresentationDelayon the attribute's default definition instead of using constants in theSegmentTemplatemethods