stream.segmented: properly fix wait() in writer#5237
Merged
bastimeyer merged 1 commit intoMar 11, 2023
Merged
Conversation
Follow-up of f234c69 Properly fix the `SegmentedStreamWriter`'s `_wait` Event when closing the thread. Depending on which thread attempted to close the writer thread, the `close()` method's `self.reader.close()` call can block, leading to the `_wait` event to not get set until all threads have terminated and joined. So make sure to set the event first, so that all threads of the writer's thread-pool executor can be stopped first, for example segment downloads waiting for the segment's availability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of f234c69
Properly fix the
SegmentedStreamWriter's_waitEvent when closing the thread.Depending on which thread attempted to close the writer thread, the
close()method'sself.reader.close()call can block, leading to the_waitevent to not get set until all threads have terminated and joined. So make sure to set the event first, so that all threads of the writer's thread-pool executor can be stopped first, for example segment downloads waiting for the segment's availability.Follow-up of #5236