build: update version range of urllib3#5325
Merged
Merged
Conversation
Member
Author
|
Apparently they won't bump the major version: This change is required now, otherwise we're having the breaking change described in #5324. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib3is a transitive dependency ofstreamlink, viarequests.We define it here too because of the main CLI module which lists all direct dependencies from the package's metadata (via
importlib.metadata) when the log level is <= debug, and listing urllib3 is useful. Another reason is that we're applying a couple of urllib3 overrides.We don't specify an upper version limit though. This is only done by requests, namely
<1.27. Now that urllib3 has published its 2.0 release last week, there are some issues. For some reason, the version doesn't always get resolved correctly by pip. I just noticed that in theget-dependencies.shscript of the Windows builds which unnecessarily downloads and tries to build urllib3 2.x until it falls back to 1.x. And then there was #5324 yesterday.So let's set the max version here too in order to avoid any confusion and to fix any dependency resolving issues.
requestswon't bumpurllib3without having a major version bump on its own.