webbrowser.cdp: implement CDP connection#5388
Merged
Merged
Conversation
4 tasks
56878c2 to
0b44b93
Compare
0b44b93 to
28b32e0
Compare
Member
Author
|
Rebased to current head of master, because this PR is the base branch for other PRs until it got merged into master. |
1994d2f to
441c04d
Compare
441c04d to
d22aa93
Compare
Member
Author
|
Rebased to master (unrelated commits are now gone from the branch), added missing docs notes of the trio-websocket and typing-extensions dependencies, and removed backported import of AsyncMock (py37) |
snorkelopstesting2-coder
pushed a commit
to snorkel-marlin-repos/streamlink_streamlink_pr_5388_591e97a6-acb4-41e9-bb1b-4cea41c8f528
that referenced
this pull request
Oct 22, 2025
Original PR #5388 by bastimeyer Original: streamlink/streamlink#5388
snorkelopstesting4-web
added a commit
to snorkel-marlin-repos/streamlink_streamlink_pr_5388_591e97a6-acb4-41e9-bb1b-4cea41c8f528
that referenced
this pull request
Oct 22, 2025
Merged from original PR #5388 Original: streamlink/streamlink#5388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/4 of #5380
This currently includes the commits of #5381 (part 1) and #5386 (part 2), because this code is needed for the CDP connection stuff. Once those PRs have been merged into master, I will rebase this branch.
So the only relevant commits of this PR are the ones after the merge commit. See the check marks of the HEAD commits of those other branches.
This
trio-websocketandtyping-extensionsruntime dependencies.typing-extensionsis required, because I neededTypeAliasfor making theCDPEventListener's typing work. This conveniently also addsSelfand other things.trio-chrome-devtools-protocolproject, which uses the MIT license. This is properly annotated with the included license text. I applied several improvements and fixes to the code. This is all fully tested with full coverage.from __future__ import annotationsworkaround so the memory channels can have proper typing information, which is important. This will be resolved in their next release (they are waiting for the EOL of py37), but I don't think it's worth removing the import and bumping the version requirement once it's released.