plugins.showroom: fix room-id schema#5390
Merged
bastimeyer merged 1 commit intoJun 21, 2023
Merged
Conversation
gravyboat
approved these changes
Jun 21, 2023
gravyboat
left a comment
Member
There was a problem hiding this comment.
Code looks good pending testing.
|
Yes all issues have been fixed. I've tested this by: running streamlink nonstop (using the bat file) for 3hrs each on 2 different offline showroom streams. Streamlink did not record any random online streams anymore, and it started recording immediately once the specified stream is online. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5389
@CplSgt82 please check and see if this fixes the issue.
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback