stream.segmented: basic code refactoring#5504
Merged
bastimeyer merged 5 commits intoAug 19, 2023
Merged
Conversation
- Move worker below writer, so it aligns with the definitions in modules of subclasses, like HLS and DASH - Reformat docstrings
- Rename `futures` to `_queue` - Change item format to `tuple[BaseSegment, Future, tuple] | None`
- Remove invalid `retries` keyword from `fetch()` call added to the `ThreadPoolExecutor` - Update DASH accordingly. Other subclasses are not affected, because they define their own `put()` method
The argument is unused in the various segmented stream implementations and the timeout gets set via the `stream-timeout` session option.
6b33bfc to
892f0b9
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some basic/trivial changes which should be done before attempting to resolve #5498.
Opening this as a draft, as I'm not sure if more is needed... Will update once I've had the time for another look in the next couple of days or so...