build: include build-shell-completions.sh in sdist#5625
Merged
bastimeyer merged 1 commit intoOct 21, 2023
Merged
Conversation
gravyboat
approved these changes
Oct 19, 2023
5918046 to
6a285c2
Compare
Member
Author
|
Removed the second commit... I will remove the I already have something ready here on my system, but before I'm opening a new PR, I will need to perform some additional checks. Going to merge this PR here now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packagers are currently patching the versioningit fallback version string, which isn't meant for setting the right version. It's a fallback for when not using the dist tarball or a git repo with at least one tag.
The packagers need to do that because they incorrectly use the tarball generated by GitHub as package source instead of our signed sdist tarball which has the right version string already built in.
The second commit therefore adds and updates the version string comments accordingly, while the first one adds the missing shell completions build-script to the sdist, despite the sdist including pre-built shell completions in the
completionsdirectory, so that there's no need to ever use the GH tarball, even when building the completions manually.