plugins.twitch: drop --twitch-disable-reruns#5704
Merged
bastimeyer merged 1 commit intoDec 5, 2023
Merged
Conversation
4 tasks
Member
Author
|
No idea where the linting issue is coming from. I have the same deps on my system. |
de79408 to
ff15b78
Compare
- Remove rerun check and disable --twitch-disable-reruns plugin argument - Implement a new `_check_is_live()` which checks the channel and stream status, based on the previously used `StreamMetadata` GQL query - Update tests
ff15b78 to
8eb16ea
Compare
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_check_is_live()which checks the channel and stream status, based on the previously usedStreamMetadataGQL queryFixes #5703
Resolves #5656
Twitch doesn't list this in their API changelog, but reruns were removed some time ago, and streamers can't use VODs anymore to go live automatically. This means that the
--twitch-disable-rerunsplugin argument and the API check it did has to be removed.In #5703 I initially commented about a different GQL query, but the old
StreamMetadataquery previously used by the rerun check can be reused here, as it returns the same data, in addition to more data we don't care about.Quick test:
unknown channel
offline channel
live channel
suppressed plugin argument
retry streams with cleaner error message