Thanks to visit codestin.com
Credit goes to github.com

Skip to content

plugins.artetv: rewrite and fix plugin#5774

Merged
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/artetv/fix-plugin
Jan 14, 2024
Merged

plugins.artetv: rewrite and fix plugin#5774
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/artetv/fix-plugin

Conversation

@bastimeyer

@bastimeyer bastimeyer commented Jan 14, 2024

Copy link
Copy Markdown
Member

Resolves #5773

More plugin changes than adding API_HLS_NG were required. This PR also fixes some other plugin implementation issues.

@Firmeware please check and see if any streams are not working with this plugin version:
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback

I only checked the live streams and a couple of VODs, but I'm not fully sure if I missed something. The API authorization token was removed, because it was not set in my web browser. I don't know why it was set in the plugin previously, but it's possible that some content might require it.
https://github.com/streamlink/streamlink/blame/6.5.0/src/streamlink/plugins/artetv.py#L31

$ ./script/test-plugin-urls.py artetv
:: Finding streams for URL: https://www.arte.tv/de/live
:: Found streams: 180p_alt, 180p, 240p_alt, 240p, 360p_alt, 360p, 540p_alt, 540p, 720p_alt, 720p, worst, best
:: Finding streams for URL: https://www.arte.tv/de/live/
:: Found streams: 180p_alt, 180p, 240p_alt, 240p, 360p_alt, 360p, 540p_alt, 540p, 720p_alt, 720p, worst, best
:: Finding streams for URL: https://www.arte.tv/de/videos/097372-001-A/mysterium-satoshi-bitcoin-wie-alles-begann-1-6/
:: Found streams: 216p, 360p, 432p, 720p, worst, best
:: Finding streams for URL: https://www.arte.tv/en/videos/097372-001-A/the-satoshi-mystery-the-story-of-bitcoin/
:: Found streams: 216p, 360p, 432p, 720p, worst, best
:: Finding streams for URL: https://www.arte.tv/fr/direct
:: Found streams: 180p_alt, 180p, 240p_alt, 240p, 360p_alt, 360p, 540p_alt, 540p, 720p_alt, 720p, worst, best
:: Finding streams for URL: https://www.arte.tv/fr/direct/
:: Found streams: 180p_alt, 180p, 240p_alt, 240p, 360p_alt, 360p, 540p_alt, 540p, 720p_alt, 720p, worst, best
:: Finding streams for URL: https://www.arte.tv/guide/de/097372-001-A/mysterium-satoshi-bitcoin-wie-alles-begann-1-6/
:: Found streams: 216p, 360p, 432p, 720p, worst, best
:: Finding streams for URL: https://www.arte.tv/guide/en/097372-001-A/the-satoshi-mystery-the-story-of-bitcoin/
:: Found streams: 216p, 360p, 432p, 720p, worst, best

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jan 14, 2024
gravyboat
gravyboat approved these changes Jan 14, 2024
View reviewed changes

@gravyboat gravyboat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good so I'll mark as approved pending confirmation from the issue reporter.

@Firmeware

Firmeware commented Jan 14, 2024

Copy link
Copy Markdown

@bastimeyer
It's work with yours changes

 [arch@archLinux ]$ sudo cp  ~/Téléchargements/artetv.py  /usr/lib/python3.11/site-packages/streamlink/plugins/artetv.py 
[arch@archLinux ]$ savestream https://www.arte.tv/fr/videos/111697-000-A/y-a-t-il-un-francais-dans-la-salle/  titi 
[cli][info] Found matching plugin artetv for URL https://www.arte.tv/fr/videos/111697-000-A/y-a-t-il-un-francais-dans-la-salle/
[cli][info] Available streams: 216p (worst), 360p, 432p, 720p, 1080p (best)
[cli][info] Opening stream: 1080p (hls-multi)
[cli][info] Writing output to
/partilha/dwhelper/titi.ts
[utils.named_pipe][info] Creating pipe streamlinkpipe-476825-1-190
[utils.named_pipe][info] Creating pipe streamlinkpipe-476825-2-2289
[download] Written 1.65 GiB to titi.ts (52s @ 33.17 MiB/s)                                                                                                                                      
[cli][info] Stream ended
[cli][info] Closing currently open stream...

Thanks

@bastimeyer bastimeyer merged commit 6d51175 into streamlink:master Jan 14, 2024
@bastimeyer bastimeyer deleted the plugins/artetv/fix-plugin branch January 14, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gravyboat gravyboat gravyboat approved these changes

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugins.artetv: error: Unable to validate response text: ValidationError(dict):

3 participants

@bastimeyer @Firmeware @gravyboat