Thanks to visit codestin.com
Credit goes to github.com

Skip to content

plugins.ustvnow: update matcher, reformat code#5881

Merged
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/ustvnow/5431
Mar 9, 2024
Merged

plugins.ustvnow: update matcher, reformat code#5881
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:plugins/ustvnow/5431

Conversation

@bastimeyer

Copy link
Copy Markdown
Member

Closes #5431

Completely untested. See #5431 (comment)

Since nobody even responded to my request, I'm opening this PR myself, even though I can't access any of these streams. There's a lot more wrong with this plugin, namely bad regexes and missing validation schemas, but I won't touch anything that I can't validate.

@pepsik-kiev @MajinLugia please give this PR a test and report back with a full --loglevel=debug output without running any third party software that embeds or launches Streamlink.
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback

If there's no feedback, then I'm going to remove the plugin instead, because I can't maintain it myself, and nobody else with access has shown any interest whatsoever in maintaining it.

@gravyboat

Copy link
Copy Markdown
Member

If there's no feedback, then I'm going to remove the plugin instead, because I can't maintain it myself, and nobody else with access has shown any interest whatsoever in maintaining it.

Sounds like the better plan to me!

@MajinLugia

MajinLugia commented Mar 9, 2024

Copy link
Copy Markdown

C:\Users\user>streamlink --loglevel debug https://www.ustvnow.com/channel/live/pbs_kids best --ustvnow-username [email protected] --ustvnow-password censored
[session][info] Plugin ustvnow is being overridden by C:\Users\user\AppData\Roaming\streamlink\plugins\ustvnow.py
[cli][debug] OS: Windows 11
[cli][debug] Python: 3.12.2
[cli][debug] OpenSSL: OpenSSL 3.0.13 30 Jan 2024
[cli][debug] Streamlink: 6.6.2
[cli][debug] Dependencies:
[cli][debug] certifi: 2024.2.2
[cli][debug] isodate: 0.6.1
[cli][debug] lxml: 5.1.0
[cli][debug] pycountry: 23.12.11
[cli][debug] pycryptodome: 3.20.0
[cli][debug] PySocks: 1.7.1
[cli][debug] requests: 2.31.0
[cli][debug] trio: 0.24.0
[cli][debug] trio-websocket: 0.11.1
[cli][debug] typing-extensions: 4.9.0
[cli][debug] urllib3: 2.2.0
[cli][debug] websocket-client: 1.7.0
[cli][debug] Arguments:
[cli][debug] url=https://www.ustvnow.com/channel/live/pbs_kids
[cli][debug] stream=['best']
[cli][debug] --loglevel=debug
[cli][debug] --ffmpeg-ffmpeg=C:\Program Files\Streamlink\ffmpeg\ffmpeg.exe
[cli][debug] --ustvnow-username=[email protected]
[cli][debug] --ustvnow-password=********
[cli][info] Found matching plugin ustvnow for URL https://www.ustvnow.com/channel/live/pbs_kids
[plugins.ustvnow][debug] Trying to login...
[plugins.ustvnow][debug] Getting new session token
[plugins.ustvnow][debug] New token: 8d50966d-1b64-46e2-a195-66762d7de71e
[utils.l10n][debug] Language code: en_US
[cli][info] Available streams: 360p (worst), 480p, 720p (best)
[cli][info] Opening stream: 720p (hls)
[cli][info] Starting player: C:\Program Files\VideoLAN\VLC\vlc.exe
[stream.hls][debug] Reloading playlist
[cli][debug] Pre-buffering 8192 bytes
[stream.hls][debug] First Sequence: 29326; Last Sequence: 29335
[stream.hls][debug] Start offset: 0; Duration: None; Start Sequence: 29333; End Sequence: None
[stream.hls][debug] Adding segment 29333 to queue
[stream.hls][debug] Adding segment 29334 to queue
[stream.hls][debug] Adding segment 29335 to queue
[stream.hls][debug] Writing segment 29333 to output
[stream.hls][debug] Segment 29333 complete
[cli.output][debug] Opening subprocess: ['C:\Program Files\VideoLAN\VLC\vlc.exe', '--input-title-format', 'https://www.ustvnow.com/channel/live/pbs_kids', '-']
[stream.hls][debug] Writing segment 29334 to output
[stream.hls][debug] Segment 29334 complete
[cli][debug] Writing stream to output
[stream.hls][debug] Writing segment 29335 to output
[stream.hls][debug] Segment 29335 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29336 to queue
[stream.hls][debug] Writing segment 29336 to output
[stream.hls][debug] Segment 29336 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29337 to queue
[stream.hls][debug] Adding segment 29338 to queue
[stream.hls][debug] Writing segment 29337 to output
[stream.hls][debug] Segment 29337 complete
[stream.hls][debug] Writing segment 29338 to output
[stream.hls][debug] Segment 29338 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29339 to queue
[stream.hls][debug] Writing segment 29339 to output
[stream.hls][debug] Segment 29339 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29340 to queue
[stream.hls][debug] Writing segment 29340 to output
[stream.hls][debug] Segment 29340 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29341 to queue
[stream.hls][debug] Writing segment 29341 to output
[stream.hls][debug] Segment 29341 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29342 to queue
[stream.hls][debug] Adding segment 29343 to queue
[stream.hls][debug] Writing segment 29342 to output
[stream.hls][debug] Segment 29342 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29344 to queue
[stream.hls][debug] Writing segment 29343 to output
[stream.hls][debug] Segment 29343 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 29345 to queue
[stream.hls][debug] Writing segment 29344 to output
[stream.hls][debug] Segment 29344 complete

@bastimeyer bastimeyer merged commit 7bc71a3 into streamlink:master Mar 9, 2024
@bastimeyer bastimeyer deleted the plugins/ustvnow/5431 branch March 9, 2024 12:02
@bastimeyer

Copy link
Copy Markdown
Member Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugins.ustvnow: pluginmatcher URL update needed

3 participants