Thanks to visit codestin.com
Credit goes to github.com

Skip to content

build: set trio min-requirement back to 0.22#5902

Merged
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:dependencies/trio-0.22
Mar 22, 2024
Merged

build: set trio min-requirement back to 0.22#5902
bastimeyer merged 1 commit into
streamlink:masterfrom
bastimeyer:dependencies/trio-0.22

Conversation

@bastimeyer

@bastimeyer bastimeyer commented Mar 22, 2024

Copy link
Copy Markdown
Member
  • set strict_exception_groups=True in CDPClient.launch()
  • monkey-patch trio.run() early in Streamlink's tests

This lifts the dependency requirements of Streamlink a bit. I didn't want to do this initially and bumped trio to >=0.25 in #5895, because it requires patching trio.run() in Streamlink's tests, as pytest-trio doesn't allow setting custom trio.run() args/kwargs.

Since packagers of some Linux distros like Debian have to apply the same kind of patch in order to package Streamlink 6.7.1, we should instead apply the version compatibility fixes here ourselves.

- set `strict_exception_groups=True` in `CDPClient.launch()`
- monkey-patch `trio.run()` early in Streamlink's tests
@bastimeyer

Copy link
Copy Markdown
Member Author
$ pip install trio==0.22
Collecting trio==0.22
  Using cached trio-0.22.0-py3-none-any.whl.metadata (4.6 kB)
Requirement already satisfied: attrs>=19.2.0 in /home/basti/venv/streamlink-312/lib/python3.12/site-packages (from trio==0.22) (23.2.0)
Requirement already satisfied: sortedcontainers in /home/basti/venv/streamlink-312/lib/python3.12/site-packages (from trio==0.22) (2.4.0)
Requirement already satisfied: async-generator>=1.9 in /home/basti/venv/streamlink-312/lib/python3.12/site-packages (from trio==0.22) (1.10)
Requirement already satisfied: idna in /home/basti/venv/streamlink-312/lib/python3.12/site-packages (from trio==0.22) (3.6)
Requirement already satisfied: outcome in /home/basti/venv/streamlink-312/lib/python3.12/site-packages (from trio==0.22) (1.3.0.post0)
Requirement already satisfied: sniffio in /home/basti/venv/streamlink-312/lib/python3.12/site-packages (from trio==0.22) (1.3.1)
Using cached trio-0.22.0-py3-none-any.whl (384 kB)
Installing collected packages: trio
  Attempting uninstall: trio
    Found existing installation: trio 0.25.0
    Uninstalling trio-0.25.0:
      Successfully uninstalled trio-0.25.0
Successfully installed trio-0.22.0

$ pytest >/dev/null; echo $?
0

@bastimeyer bastimeyer merged commit 78d0b58 into streamlink:master Mar 22, 2024
@bastimeyer bastimeyer deleted the dependencies/trio-0.22 branch March 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant