plugins.afreeca: Support for password-protected streams#5952
Merged
bastimeyer merged 1 commit intoApr 20, 2024
Merged
Conversation
bastimeyer
reviewed
Apr 19, 2024
Contributor
Author
|
I tried fixing it, but I'm not sure if this is the right way to do it since I'm not very good with Python. |
bastimeyer
reviewed
Apr 20, 2024
bastimeyer
left a comment
Member
There was a problem hiding this comment.
In my opinion, this will create conflicts with other PRs.
There will be merge conflicts anyway because you've opened two PRs (with separate branches - obviously).
Just rebase and force-push once the other PR got merged. Force-pushing with rebased/amended commits is always better than adding multiple commits to the branch, because I'll have to squash-merge in this case. I can review rebased and force-pushed branches just fine, even complex ones. This one here is dead simple.
bastimeyer
reviewed
Apr 20, 2024
02cc2d6 to
8ea10ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I used the correct password:
When I used the wrong password: