plugins.chzzk: live detail api response validation error fix#6002
Conversation
bastimeyer
left a comment
There was a problem hiding this comment.
Thanks for the PR. Changes look fine.
However, should there be a need for extending the validation schemas even further, then I'd say that the error handling code should be moved from the Plugin subclass (_get_live() and _get_video()) to the API class. The error handling is currently done in the Plugin subclass, so that it can simply return None instead of having to raise a NoStreamsError in the API class. Irrelevant here though, just a quick thought...
Talking about error handling, are VODs also affected by a potential None return type?
|
Not affected, based on VODs I've tested. All the VODs have non-null And I agree with what you said. Raising |
Fixes: #6001
Any better suggestions are welcome.