plugins.yupptv: refactor and fix plugin#6093
Merged
Merged
Conversation
b570b3c to
da21fb0
Compare
|
It looks good to me. Thank you. Here is a sample debug log in a gist. https://gist.github.com/DeltaEpsilon19498/09daaa2db2c9284a7d6172c8b15b199a |
Member
Author
|
Well, thanks, but I asked for feedback on other channels, specifically ones with ads. Going to merge this now anyway because I doubt there are any issues... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6092
The plugin extracted the wrong HLS playlist URL from their (garbage) JS code. This is fixed now. I've also refactored the plugin and fixed the bad code style, and I implemented ad filtering, as most streams seem to have preroll ads which then cause an unnecessary stream discontinuity. Ad segments apparently are lacking the
.tsfile extension in the segment URLs, which is used to detect ads. Hopefully this doesn't break actual stream segments. Seemed fine in the streams I checked though. I didn't touch the plugin's authentication logic. No idea if this is working at all. I don't really care though.@DeltaEpsilon19498 please check the plugin changes and see if any streams which I didn't test are not working correctly
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback