plugins.youtube: check VOD URLs, raise PluginError#6135
Merged
bastimeyer merged 1 commit intoAug 20, 2024
Merged
Conversation
7918846 to
ad20b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6060
This adds the following error message for VOD content with 4xx HTTP error responses
and updates the existing error message for protected videos
The protected video stuff is actually useless now, but I didn't want to make any significant plugin changes, so it'll be kept.
In order to fix VOD content, we'd need to implement YouTube's adaptive stream URL signatures. As said, I'm not interested in implementing this myself, so if someone wants this to be fixed, they'll need to submit a PR with working code and be willing to keep the plugin maintained.
Live content is of course still working fine.