plugins.facebook: remove plugin#6199
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6158 / #6158 (comment)
Closes #4800
The plugin is broken, unmaintained and hasn't been updated in years:
https://github.com/streamlink/streamlink/commits/6.10.0/src/streamlink/plugins/facebook.py
The current implementation apparently aimed at supporting videos from user feeds. As said in #6158, I don't have a Facebook account. Creating a new one without valid personal data doesn't work reliably and they'll block/ban you immediately, which makes this unnecessarily difficult. I therefore don't have any interest in fixing this.
Facebook's "new" livestreaming service however was never supported by the plugin
https://www.facebook.com/watch/live
If anyone wants support for this, they can submit a new working plugin implementation. This plugin removal simply gets rid of the broken code, so that we don't incorrectly advertise support for that site.