plugins: fix broken matcher capture groups#6368
Merged
bastimeyer merged 1 commit intoDec 30, 2024
Merged
Conversation
Verbose plugin matcher regexes of some plugins were split into multiple simple matchers in 742988f. Some regex capture group references however were not updated, resulting in `IndexError` being raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verbose plugin matcher regexes of some plugins were split into multiple simple matchers in 742988f.
Some regex capture group references however were not updated, resulting in
IndexErrorbeing raised.Fixes #6366
See #6363, #6364
Here's the list of all updated plugins in 742988f and their current number of
@pluginmatchers, with allself.match/self.matchesreferences (for accessing matchers and their regex capture groups).Plugins with only one matcher, or plugins which don't look up regex capture groups could be ignored. Other ones had to be investigated.