plugins.nicolive: filter out blank segments#6476
Conversation
|
Hi, I've tested the new nicolive.py and my issue has been resolved. Audio&video are good and no sync issues. Command used: streamlink -o "outputs/{author}/{title}-{time:%Y-%m-%d-%H-%M-%S}.ts" --ffmpeg-copyts --logfile log-streamlink.txt --loglevel all https://live.nicovideo.jp/watch/lv347277552 best Version: streamlink 7.1.3+26.g6e8d7ce Attached logfile if interested. Thankyou! |
|
I'm using ChatGPT to translate from Japanese to English, so I apologize if the grammar is incorrect. I have confirmed that all of the following broadcasts can be downloaded successfully. For the nicolive.py that was submitted as this pull request, there were broadcasts where the video would not play correctly unless
Additionally, I confirmed that all broadcasts, such as official broadcasts that do not require Checked broadcasts: |
👍 According to the log output, the But please don't overwrite/replace the plugin file directly. Have a look at the PR feedback link I've posted earlier. You're supposed to install+run the PR branch or sideload the modified plugin file. You're doing neither.
It's a VOD, so there's no sync issue to be expected because both playlists will start at the same time, regardless of access time, unlike live playlists, as explained in the other PR. You also don't need the
All of these links are restricted and can't be accessed.
But without any useful debug logs, none of your claims can be checked. Btw, this is totally unrelated to this pull request. If there is a plugin issue that can be reliably reproduced, then please open a plugin issue thread and don't comment here. |
Ref #6441 (comment)
@SecondaryH please test...
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
Since there has been no follow up to my request in the linked thread, I haven't tested these changes myself. These were purely done by reading the posted log output.