plugins.twitcasting: filter preroll segments#6601
Merged
Merged
Conversation
|
hi, i know this might be out-of-scope, but would you know how to potentially fix these broken files? |
Contributor
Author
If you have the original output files written by streamlink, you should be able to separate the discontinuities by splitting the file on the byte sequence |
Member
|
Thanks, @Hakkin |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitcasting serves preroll segments if you request an HLS playlist before enough video data has been sent to the server, typically within ~0-10 seconds of a stream starting. Since they're using fMP4 now, it breaks the output with a discontinutiy, so they need to be filtered.
Fixes #6600
Before
Results in broken output file
After
ffmpeg output