tests: req pytest>=8.4.0, load plugins explicitly#6612
Merged
bastimeyer merged 2 commits intoOct 26, 2025
Conversation
Add the `--disable-plugin-autoload` pytest option (pytest >=8.4.0) and explicitly load pytest plugins which are required by Streamlink's test suite. By default, pytest plugins are discovered automatically by checking all installed Python distributions in the current Python environment, which may lead to unwanted pytest plugins being loaded and executed.
Member
Author
|
Going to merge this now after 3 months of waiting... I'm not familiar with Fedora's release schedule, but they are still holding on to pytest 8.3.5 for some reason, probably because they consider it a big breaking change (upstream 8.4.0 lists breaking changes that should be irrelevant for almost all projects using pytest, unless neglected):
The other distros are small ones which have lots of outdated Python packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
--disable-plugin-autoloadpytest option (pytest >=8.4.0) and explicitly load pytest plugins which are required by Streamlink's test suite.By default, pytest plugins are discovered automatically by checking all installed Python distributions in the current Python environment, which may lead to unwanted pytest plugins being loaded and executed.
Random pytest plugins shouldn't be loaded when running the test suite.
Before merging, I'll need to have a look at which pytest versions are packaged in the main Linux distros where Streamlink is packaged. Pytest 8.4.0 is fairly recent, so this might be a problem.
Last checked: 2025-09-29