stream.hls: remove deprecated url_master arg+attr#6688
Merged
bastimeyer merged 1 commit intoOct 26, 2025
Merged
Conversation
This is mainly just used by internal code, but since it's part of the class constructors which are public interfaces, it needed a deprecation phase. It is very unlikely that third-party plugin implementors will ever create `HLSStream`/`MuxedHLSStream` instances with a reference to a multivariant/master playlist themselves. This is done automatically via the `HLSStream.parse_variant_playlist()` classmethod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly just used by internal code, but since it's part of the class constructors which are public interfaces, it needed a deprecation phase.
It is very unlikely that third-party plugin implementors will ever create
HLSStream/MuxedHLSStreaminstances with a reference to a multivariant/master playlist themselves. This is done automatically via theHLSStream.parse_variant_playlist()classmethod.Just for additional clarification, this is not about the "multivariant" and "master" terminology. The "master" name is still part of RFC 8216, and it's also still used by the
M3U8implementation (is_master). Themultivariantargument and attribute names were added with respect of the (still-in-draft-phase) HLS revisions, where this was renamed.The switch from a simple multivariant playlist URL reference to the
M3U8instance was done in 7cb0ebe.